Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Walkthrough피드 순위 산정 가중치 교체: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/java/ddingdong/ddingdongBE/domain/feed/controller/ClubFeedStatusE2ETest.java (1)
83-103: 조회수 가중치 회귀를 직접 검증하는 단언을 추가하면 더 안전합니다.현재 시나리오는
viewCount=0이라 VIEW_WEIGHT 변경(1→3)이 결과에 영향이 없어 회귀 탐지가 약합니다.viewScore단언을 추가하거나 조회수 > 0 케이스를 별도 테스트로 두는 것을 권장합니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/ddingdong/ddingdongBE/domain/feed/controller/ClubFeedStatusE2ETest.java` around lines 83 - 103, Add an assertion to verify the viewScore (or add a separate test case where viewCount > 0) so view-weight regressions are caught: in ClubFeedStatusE2ETest, after extracting response from the GET "/server/central/feeds/status" (response variable), assert the numeric value of response.get("viewScore") (cast via ((Number) response.get("viewScore")).longValue()) equals the expected viewScore for the prepared feed data; alternatively create a new test that creates a feed with viewCount > 0 and asserts feedScore/likeScore/commentScore/viewScore/totalScore accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@src/test/java/ddingdong/ddingdongBE/domain/feed/controller/ClubFeedStatusE2ETest.java`:
- Around line 83-103: Add an assertion to verify the viewScore (or add a
separate test case where viewCount > 0) so view-weight regressions are caught:
in ClubFeedStatusE2ETest, after extracting response from the GET
"/server/central/feeds/status" (response variable), assert the numeric value of
response.get("viewScore") (cast via ((Number)
response.get("viewScore")).longValue()) equals the expected viewScore for the
prepared feed data; alternatively create a new test that creates a feed with
viewCount > 0 and asserts feedScore/likeScore/commentScore/viewScore/totalScore
accordingly.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/test/java/ddingdong/ddingdongBE/domain/feed/controller/ClubFeedStatusE2ETest.java
KoSeonJe
added a commit
that referenced
this pull request
Mar 16, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 작업 내용
🤔 고민했던 내용
💬 리뷰 중점사항
🤖 Generated with Claude Code
Summary by CodeRabbit
릴리스 노트